Normalizing Online-DDL queries #7153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- CREATE INDEX formats onto ALTER TABLE - DROP TABLE <multi> - exploded into multiple single-table DROP statements Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
systay
reviewed
Dec 10, 2020
go/vt/schema/parser_test.go
Outdated
| "drop database t": {isError: true}, | ||
| } | ||
| for query, expect := range tests { | ||
| normalized, err := NormalizeOnlineDDL(query) |
There was a problem hiding this comment.
nit:
for query, expect := range tests {
t.Run(query, func(t *testing.T) {
...
})
}sub tests makes it look good in test output
|
Still have some tests to fix. |
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
Documentation: vitessio/website#638 |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
NO
Status
REAFY
Description
In this PR we normalize some DDL queries sent as Online DDL:
CREATE INDEXformats ontoALTER TABLE: this is becausegh-ostandpt-osconly know how to handleALTER TABLEstatements. As there is no specific advantage to usingCREATE INDEXover the equivalentCREATE TABLE... ADD INDEXwe choose to haveCreateIndex.Format()function export asALTER TABLEDROP TABLE <multi>- exploded into multiple single-tableDROPstatementsRelated Issue(s)
#6926 (comment)
Todos
Impacted Areas in Vitess
List general components of the application that this PR will affect:
Notes
@GuptaManan100 @systay please notice the following test from
parse_test.go:The output is incorrect; still to understand why, I think the problem is with the parser, not with the Format. FWIW MySQL itself is unhappy about that complex CREAT EINDEX query.